[Goodies-dev] ANN: xfce4-fsguard-plugin version 1.3.99.1 released

[Christian Dywan]

Heya Mike,

Am Sat, 20 Oct 2007 05:12:05 +0200
schrieb mmassonnet at gmail.com:

> Re!

I beg your pardon. I forgot to address your in the last mail. m(-_-)m

> On Fri, Oct 19, 2007 at 09:37:05PM -0700, Christian Dywan wrote:
> > Am Fri, 19 Oct 2007 12:08:05 +0200
> > schrieb mmassonnet at gmail.com:
> > > > 3. The icon is fixed to a very small size. I would expect it to
> > > > fit the height (horizontal) or width (vertical) of my panel
> > > > respectively.
> > > 
> > > That's most probably caused because of 1.
> > 
> > Great..almost. The height is perfect now and the icon fits. Yet the
> > progressbar is unnaturally wide, about four times the appropriate
> > width I'd say. It would be very nice if you could fix that.
> 
> I changed the border around the GtkProgressBar to what most current
> plugins are.  But in future this will have to change…
> 
> See http://bugzilla.xfce.org/show_bug.cgi?id=3587.
> 
> > > > 2. The label lacks padding.
> > > 
> > > I can't really tell, but it is like the systemload and battery.
> > 
> > You are right, this is not a new problem. It seems you just happen
> > to be standing in front of the bulls eye while I am practising. ;)
> > 
> > Seriously, I think a little padding is needed. Sticking stuff
> > directly together side by side is just bad. You take it for granted
> > in (well designed) dialogs, why not in the panel?
> 
> The padding is 4px now and I won't change it, unless you fix the other
> plugins and release them for the next week end. j/k
> 
> Btw, the dialog wans't well designed, now it is :)  Revision 3402.

I updated to the most recent svn version and it's very, very nice now.
I won't insist on the padding if nobody else complains.

It seems somehow the plugin confuses the values now, ie. mount point,
filemanager and name are mixed up, not sure what exactly is happening
there. I assume this is a typo or something and will be fixed soon. :) 

> > > > 4. The German translation for the first checkbox is wrong. I can
> > > > update the po file and fill the new gaps as well if you want.
> > > 
> > > Damn! :)  Go ahead.
> > > 
> > > Btw. I'm not sure yet how to call the “progress bar”, I had like
> > > to rename it to “monitor”, or …
> > 
> > In my opinion "monitor" is a bit confusing. Progressbar is in fact
> > just the name of the widget, even to anybody unfamiliar with Gtk+ in
> > particular. So progressbar is not the best name but I wouldn't be
> > able to think of a better one.
> > 
> > I will wait with the translation for now since this is undecided.
> > Feel free to address me whenever you feel I should do it.
> 
> I renamed it to "meter", and took care of the de.po file, just check
> it and poke me if I did a mistake ;-)

Ha! Meter is perfect. And the translation is nice. Just two tiny
things:

Please change "Feier Speicher anzeigen" to "Freien Speicher
anzeigen", note the accusative 'n'.

And I would ask you to localize the name of the plugin, as it appears
in the "Add item" dialog and the context menu.

> 
> > Yours,
> >     Christian
> 
> Cheerz!
> Mike

Yours,
    Christian