[Goodies-dev] xmms and timer plugins

[Kemal Eroglu]

   Hi,

   I was terribly busy this weekend, so I couldn't find the time to apply 
the patch; sorry for that. I'll continue to be busy for a while, but I'll 
do it as soon as I can. If you get svn access and apply, let me know.

   It's 5:30 am, now I shall sleep :)...

   Ilgar

  On Sun, 17 Sep 2006, gaso wrote:

> Hello Ilgar,
>
> Yes, it contains my patch and also your bug fixes of 0.4.1. But the 
> differences to the SVN will look too large because I've split xmms_plugin.c 
> to 2 files (xmms_plugin.c and preferences.c). For SVN access, I request it 
> right after this.
>
> Thanks,
> gaso
>
> Kemal Eroglu wrote:
>>    Hi gaso,
>>
>>    Do you mean this is the tarball with your patches applied to the latest 
>> SVN? Then after checking the diffs I can commit it. Of course it's 
>> perfectly fine with me if you get SVN access. I sould be able to commit 
>> this code this weekend.
>>
>>    Thanks,
>>    Ilgar
>> 
>> On Fri, 15 Sep 2006, gaso wrote:
>> 
>>> Hello Ilgar,
>>> 
>>> Thanks for your acceptance of my changes, and there is a new tarball which 
>>> applied bug fix codes from SVN trunk.
>>> 
>>> http://www.geocities.jp/ganchang_gaso/xfce4-xmms-plugin-0.5.0.tar.gz
>>> 
>>> However, what should I do to incorporate the code into a new branch? 
>>> Should I request SVN access? or could you update it?
>>> 
>>> 
>>> thanks,
>>> gaso
>>> 
>>> Kemal Eroglu wrote:
>>>>   Hi gaso,
>>>>
>>>>   I applied the patches for the issues you mentioned in your previous 
>>>> post, the version is now 0.4.2, thanks a lot. I think this code can be 
>>>> tagged now and we can move on with a new branch incorporating your other 
>>>> changes.
>>>>
>>>>   Ilgar
>>>> 
>>>> On Fri, 1 Sep 2006, gaso wrote:
>>>> 
>>>>> If my code would be applied, I think it is better to move to next 
>>>>> version because it changes basic part of the plugin. In fact, there 
>>>>> isn't too much difference between two codes, but they don't have 
>>>>> compatibility.
>>>>> 
>>>>> # in Japan, we've still been having humid and hot summer, so please take 
>>>>> care of yourself.
>>>>> 
>>>>> Thanks,
>>>>> gaso
>>>>> 
>>>>> Kemal Eroglu wrote:
>>>>>>    Sorry for not replying to the last message in the thread, my 
>>>>>> maillist setting was plain text instead of mime.
>>>>>>
>>>>>>    Thanks for your reply gaso. I'm going to Japan next week so I'll be 
>>>>>> unavailable for a while, but after I'm back we can continue on this. If 
>>>>>> the changes are too big, we may finalize and tag the old xmms-targeted 
>>>>>> plugin and then bump the major version to a new one to incorporate the 
>>>>>> new features.
>>>>>>
>>>>>>    Take care,
>>>>>>
>>>>>>    Ilgar
>>>>>> 
>>>>>> On Thu, 31 Aug 2006, goodies-dev-request at xfce.org wrote:
>>>>>>> Message: 1
>>>>>>> Date: Thu, 31 Aug 2006 07:38:53 +0900
>>>>>>> From: gaso <ganchang_mrlbr at ybb.ne.jp>
>>>>>>> Subject: Re: [Goodies-dev] xmms and timer plugins
>>>>>>> To: Xfce Goodies development discussion <goodies-dev at xfce.org>
>>>>>>> Message-ID: <44F6137D.4080802 at ybb.ne.jp>
>>>>>>> Content-Type: text/plain; charset="iso-8859-1"
>>>>>>> 
>>>>>>> Hello Ilgar,
>>>>>>> 
>>>>>>> I want to use xmms-plugin as a "client" of XMMS compatible media
>>>>>>> players, and I implements some features, e.g. dynamic library loading,
>>>>>>> XMMS controlling functions.
>>>>>>> source is here (details are in README):
>>>>>>> http://www.geocities.jp/ganchang_gaso/xfce4-xmms-plugin.tar.gz
>>>>>>> 
>>>>>>> Unfortunately, I made these changes before your posting, so I changed
>>>>>>> many structure of the code at my choice. I'm sorry I can't show you
>>>>>>> simple patch. I hope you can understand what I want in this plugin.
>>>>>>> 
>>>>>>> By the way, latest xmms-plugin seems still have some bugs
>>>>>>> * Gtk warning occurs at the plugin starting time if XMMS isn't running
>>>>>>> * "Horizontal volume bar on vertical panels" option ignores "Show 
>>>>>>> volume
>>>>>>> level" setting
>>>>>>> * resized to incorrect size by "size-change" signal
>>>>>>> * wrong value is set to height of volume bar if panel and volume bar 
>>>>>>> are
>>>>>>> vertical
>>>>>>> * It seems volume bar width is too thick when panel is horizontal (I
>>>>>>> don't fix this)
>>>>>>> the patch is attached to this mail (xfce4-xmms-plugin-fixbugs.patch).
>>>>>>> 
>>>>>>> thanks,
>>>>>>> gaso
>>>>>> _______________________________________________
>>>>>> Goodies-dev mailing list
>>>>>> Goodies-dev at xfce.org
>>>>>> http://foo-projects.org/mailman/listinfo/goodies-dev
>>>>>> 
>>>>> -- 
>>>>> gaso <ganchang_mrlbr at ybb.ne.jp>
>>>>> 
>>>>> 
>>>> _______________________________________________
>>>> Goodies-dev mailing list
>>>> Goodies-dev at xfce.org
>>>> http://foo-projects.org/mailman/listinfo/goodies-dev
>>>> 
>>> -- 
>>> gaso <ganchang_mrlbr at ybb.ne.jp>
>>> 
>>> 
>> _______________________________________________
>> Goodies-dev mailing list
>> Goodies-dev at xfce.org
>> http://foo-projects.org/mailman/listinfo/goodies-dev
>> 
>
> -- 
> gaso <ganchang_mrlbr at ybb.ne.jp>
>
>