[Goodies-commits] r7024 - in xfmpc: branches/xfmpc-0.1.x branches/xfmpc-0.1.x/src trunk trunk/src

Mike Massonnet mmassonnet at xfce.org
Sun Mar 29 12:47:04 CEST 2009


Author: mmassonnet
Date: 2009-03-29 10:47:04 +0000 (Sun, 29 Mar 2009)
New Revision: 7024

Modified:
   xfmpc/branches/xfmpc-0.1.x/ChangeLog
   xfmpc/branches/xfmpc-0.1.x/src/extended-interface.c
   xfmpc/branches/xfmpc-0.1.x/src/playlist.c
   xfmpc/trunk/ChangeLog
   xfmpc/trunk/src/extended-interface.c
   xfmpc/trunk/src/playlist.c
Log:
Fix segfault when retrieving information of no song

Modified: xfmpc/branches/xfmpc-0.1.x/ChangeLog
===================================================================
--- xfmpc/branches/xfmpc-0.1.x/ChangeLog	2009-03-29 10:45:56 UTC (rev 7023)
+++ xfmpc/branches/xfmpc-0.1.x/ChangeLog	2009-03-29 10:47:04 UTC (rev 7024)
@@ -1,3 +1,9 @@
+2009-03-29	Mike Massonnet <mmassonnet at xfce.org>
+
+Fix segfault when retrieving information of no song
+	* src/playlist.c(cb_info_selection):
+	  - Return if list is null
+
 2009-03-28	Mike Massonnet <mmassonnet at xfce.org>
 
 === Release 0.1.0 ===

Modified: xfmpc/branches/xfmpc-0.1.x/src/extended-interface.c
===================================================================
--- xfmpc/branches/xfmpc-0.1.x/src/extended-interface.c	2009-03-29 10:45:56 UTC (rev 7023)
+++ xfmpc/branches/xfmpc-0.1.x/src/extended-interface.c	2009-03-29 10:47:04 UTC (rev 7024)
@@ -28,7 +28,6 @@
 #include "mpdclient.h"
 #include "playlist.h"
 #include "dbbrowser.h"
-#include "statusbar.h"
 #include "xfce-arrow-button.h"
 #include "preferences-dialog.h"
 #include "preferences.h"

Modified: xfmpc/branches/xfmpc-0.1.x/src/playlist.c
===================================================================
--- xfmpc/branches/xfmpc-0.1.x/src/playlist.c	2009-03-29 10:45:56 UTC (rev 7023)
+++ xfmpc/branches/xfmpc-0.1.x/src/playlist.c	2009-03-29 10:47:04 UTC (rev 7024)
@@ -683,6 +683,9 @@
     return;
 
   list = gtk_tree_selection_get_selected_rows (selection, &store);
+  if (list == NULL)
+    return;
+
   if (gtk_tree_model_get_iter (store, &iter, list->data))
     {
       gtk_tree_model_get (store, &iter,

Modified: xfmpc/trunk/ChangeLog
===================================================================
--- xfmpc/trunk/ChangeLog	2009-03-29 10:45:56 UTC (rev 7023)
+++ xfmpc/trunk/ChangeLog	2009-03-29 10:47:04 UTC (rev 7024)
@@ -1,3 +1,9 @@
+2009-03-29	Mike Massonnet <mmassonnet at xfce.org>
+
+Fix segfault when retrieving information of no song
+	* src/playlist.c(cb_info_selection):
+	  - Return if list is null
+
 2009-03-28	Mike Massonnet <mmassonnet at xfce.org>
 
 === Release 0.1.0 ===

Modified: xfmpc/trunk/src/extended-interface.c
===================================================================
--- xfmpc/trunk/src/extended-interface.c	2009-03-29 10:45:56 UTC (rev 7023)
+++ xfmpc/trunk/src/extended-interface.c	2009-03-29 10:47:04 UTC (rev 7024)
@@ -28,7 +28,6 @@
 #include "mpdclient.h"
 #include "playlist.h"
 #include "dbbrowser.h"
-#include "statusbar.h"
 #include "xfce-arrow-button.h"
 #include "preferences-dialog.h"
 #include "preferences.h"

Modified: xfmpc/trunk/src/playlist.c
===================================================================
--- xfmpc/trunk/src/playlist.c	2009-03-29 10:45:56 UTC (rev 7023)
+++ xfmpc/trunk/src/playlist.c	2009-03-29 10:47:04 UTC (rev 7024)
@@ -683,6 +683,9 @@
     return;
 
   list = gtk_tree_selection_get_selected_rows (selection, &store);
+  if (list == NULL)
+    return;
+
   if (gtk_tree_model_get_iter (store, &iter, list->data))
     {
       gtk_tree_model_get (store, &iter,




More information about the Goodies-commits mailing list