[Goodies-commits] r7569 - in xfce4-notes-plugin/trunk: . panel-plugin

Mike Massonnet mmassonnet at xfce.org
Sun Jun 14 16:35:53 CEST 2009


Author: mmassonnet
Date: 2009-06-14 14:35:53 +0000 (Sun, 14 Jun 2009)
New Revision: 7569

Modified:
   xfce4-notes-plugin/trunk/ChangeLog
   xfce4-notes-plugin/trunk/panel-plugin/main.vala
Log:
Properly shutdown Xfconf

Modified: xfce4-notes-plugin/trunk/ChangeLog
===================================================================
--- xfce4-notes-plugin/trunk/ChangeLog	2009-06-14 13:04:26 UTC (rev 7568)
+++ xfce4-notes-plugin/trunk/ChangeLog	2009-06-14 14:35:53 UTC (rev 7569)
@@ -1,25 +1,34 @@
-2009-06-09  Mike Massonnet <mmassonnet at xfce.org>
+2009-06-14  Mike Massonnet <mmassonnet at xfce.org>
 
+Properly shutdown Xfconf
+	* panel-plugin/main.vala:
+	  - On NotesPlugin destruction, destroy application as to call its
+	  destructor and save the settings to Xfconf before shutting Xfconf
+	  down.
+	  - Set panel_plugin a weak ref (no need to ref/unref it).
+
+2009-06-14  Mike Massonnet <mmassonnet at xfce.org>
+
 Refactorize main.vala
 
-2009-06-09  Mike Massonnet <mmassonnet at xfce.org>
+2009-06-14  Mike Massonnet <mmassonnet at xfce.org>
 
 Previous problem catched...
 
 The valac compiler doesn't like libxfcegui4+libxfce4panel...
 
-2009-06-09  Mike Massonnet <mmassonnet at xfce.org>
+2009-06-14  Mike Massonnet <mmassonnet at xfce.org>
 
 Fix compilation for libxfce4panel < 4.7
 
 It still doesn't compile, and frankly I have not the slightest bit why this is
 so. The resulting C code from main.vala does not include libxfce4panel.h.
 
-2009-06-09  Mike Massonnet <mmassonnet at xfce.org>
+2009-06-13  Mike Massonnet <mmassonnet at xfce.org>
 
 Support for libxfce4panel >= 4.7
 
-2009-06-09  Mike Massonnet <mmassonnet at xfce.org>
+2009-06-10  Mike Massonnet <mmassonnet at xfce.org>
 
 Minor automake script review
 

Modified: xfce4-notes-plugin/trunk/panel-plugin/main.vala
===================================================================
--- xfce4-notes-plugin/trunk/panel-plugin/main.vala	2009-06-14 13:04:26 UTC (rev 7568)
+++ xfce4-notes-plugin/trunk/panel-plugin/main.vala	2009-06-14 14:35:53 UTC (rev 7569)
@@ -31,11 +31,12 @@
 	private Gtk.Invisible invisible;
 	private Gtk.Button button;
 	private Gtk.Image image;
-	private Xfce.PanelPlugin panel_plugin;
+	private weak Xfce.PanelPlugin panel_plugin;
 	private Xnp.Application application;
 
 	~NotesPlugin () {
-		// FIXME: Is called before unrefing application
+		// Destroy application before calling Xfconf.shutdown()
+		application = null;
 		Xfconf.shutdown ();
 	}
 




More information about the Goodies-commits mailing list