[Goodies-commits] r6598 - in xfce4-clipman-plugin/branches/xfce-4-6: . panel-plugin

[Mike Massonnet]

Author: mmassonnet
Date: 2009-01-30 06:26:06 +0000 (Fri, 30 Jan 2009)
New Revision: 6598

Modified:
   xfce4-clipman-plugin/branches/xfce-4-6/ChangeLog
   xfce4-clipman-plugin/branches/xfce-4-6/panel-plugin/panel-plugin.c
   xfce4-clipman-plugin/branches/xfce-4-6/panel-plugin/settings-dialog.glade
Log:
Set the settings dialog "buggy".

Modified: xfce4-clipman-plugin/branches/xfce-4-6/ChangeLog
===================================================================
--- xfce4-clipman-plugin/branches/xfce-4-6/ChangeLog	2009-01-29 02:23:53 UTC (rev 6597)
+++ xfce4-clipman-plugin/branches/xfce-4-6/ChangeLog	2009-01-30 06:26:06 UTC (rev 6598)
@@ -1,3 +1,13 @@
+2009-01-30	Mike Massonnet
+Set the settings dialog "buggy".
+
+	- panel-plugin/panel-plugin.c:
+		In a way to fix weird bugs, the settings dialog is no more
+		transient for the top level widget of the panel plugin.
+	- panel-plugin/settings-dialog.glade:
+		Both dialogs "action-dialog" and "command-dialog" skip the
+		taskbar and have the type hint "dialog".
+
 2009-01-26	Mike Massonnet
 Actions are configurable through the settings dialog.
 

Modified: xfce4-clipman-plugin/branches/xfce-4-6/panel-plugin/panel-plugin.c
===================================================================
--- xfce4-clipman-plugin/branches/xfce-4-6/panel-plugin/panel-plugin.c	2009-01-29 02:23:53 UTC (rev 6597)
+++ xfce4-clipman-plugin/branches/xfce-4-6/panel-plugin/panel-plugin.c	2009-01-30 06:26:06 UTC (rev 6598)
@@ -229,12 +229,13 @@
 
   /* Settings dialog */
   dialog = glade_xml_get_widget (plugin->gxml, "settings-dialog");
-  /* FIXME Doing this with Glade makes the panel button unclickable... but
-   * still we need to destroy the dialog when the panel quits, so keep it. */
-  /* FIXME Now with the actions this bit is getting nastier... when the menu
-   * with actions should popup it is "hidden" while this dialog is shown. */
+  /* NOTE Normally the dialog should be set transient for the top level widget
+   * of the panel plugin, but it renders weird bugs doing so with either glade
+   * or glade+xfce_titled_dialog. */
+  /*
   gtk_window_set_transient_for (GTK_WINDOW (dialog),
                                 GTK_WINDOW (gtk_widget_get_toplevel (GTK_WIDGET (panel_plugin))));
+  */
 
   /* General settings */
   gtk_toggle_button_set_active (GTK_TOGGLE_BUTTON (glade_xml_get_widget (plugin->gxml, "save-on-quit")),

Modified: xfce4-clipman-plugin/branches/xfce-4-6/panel-plugin/settings-dialog.glade
===================================================================
--- xfce4-clipman-plugin/branches/xfce-4-6/panel-plugin/settings-dialog.glade	2009-01-29 02:23:53 UTC (rev 6597)
+++ xfce4-clipman-plugin/branches/xfce-4-6/panel-plugin/settings-dialog.glade	2009-01-30 06:26:06 UTC (rev 6598)
@@ -344,7 +344,7 @@
     <property name="default_height">380</property>
     <property name="destroy_with_parent">True</property>
     <property name="icon_name">system-run</property>
-    <property name="type_hint">normal</property>
+    <property name="type_hint">dialog</property>
     <property name="skip_taskbar_hint">True</property>
     <property name="transient_for">settings-dialog</property>
     <property name="has_separator">False</property>
@@ -586,7 +586,8 @@
     <property name="window_position">center-on-parent</property>
     <property name="destroy_with_parent">True</property>
     <property name="icon_name">system-run</property>
-    <property name="type_hint">normal</property>
+    <property name="type_hint">dialog</property>
+    <property name="skip_taskbar_hint">True</property>
     <property name="transient_for">entry-dialog</property>
     <property name="has_separator">False</property>
     <child internal-child="vbox">