[Goodies-commits] r5694 - xfce4-dict/trunk/lib

[Enrico Troeger]

Author: enrico
Date: 2008-10-19 09:29:52 +0000 (Sun, 19 Oct 2008)
New Revision: 5694

Modified:
   xfce4-dict/trunk/lib/dictd.c
Log:
Be safe and check array size before using it.

Modified: xfce4-dict/trunk/lib/dictd.c
===================================================================
--- xfce4-dict/trunk/lib/dictd.c	2008-10-19 09:29:50 UTC (rev 5693)
+++ xfce4-dict/trunk/lib/dictd.c	2008-10-19 09:29:52 UTC (rev 5694)
@@ -205,13 +205,15 @@
 		/* get the used dictionary */
 		dict_parts = g_strsplit(lines[i], "\"", -1);
 
-		gtk_text_buffer_insert_with_tags(dd->main_textbuffer, &dd->textiter,
-			g_strstrip(dict_parts[3]), -1, dd->main_tag_bold, NULL);
+		if (g_strv_length(dict_parts) > 3)
+		{	gtk_text_buffer_insert_with_tags(dd->main_textbuffer, &dd->textiter,
+				g_strstrip(dict_parts[3]), -1, dd->main_tag_bold, NULL);
 
-		gtk_text_buffer_insert(dd->main_textbuffer, &dd->textiter, " (", 2);
-		gtk_text_buffer_insert(dd->main_textbuffer, &dd->textiter, g_strstrip(dict_parts[2]), -1);
-		gtk_text_buffer_insert(dd->main_textbuffer, &dd->textiter, ")\n", 2);
-
+			gtk_text_buffer_insert(dd->main_textbuffer, &dd->textiter, " (", 2);
+			gtk_text_buffer_insert(dd->main_textbuffer, &dd->textiter,
+				g_strstrip(dict_parts[2]), -1);
+			gtk_text_buffer_insert(dd->main_textbuffer, &dd->textiter, ")\n", 2);
+		}
 		g_strfreev(dict_parts);
 
 		if (i >= (max_lines - 2))