[Goodies-commits] r5908 - in xfce4-screenshooter-plugin/trunk: . lib

[Jerome Guelfucci]

Author: jeromeg
Date: 2008-11-02 14:24:00 +0000 (Sun, 02 Nov 2008)
New Revision: 5908

Modified:
   xfce4-screenshooter-plugin/trunk/ChangeLog
   xfce4-screenshooter-plugin/trunk/TODO
   xfce4-screenshooter-plugin/trunk/lib/screenshooter-dialogs.c
Log:
Correctly free a lot of stuff in lib/screenshooter-dialogs.c

Modified: xfce4-screenshooter-plugin/trunk/ChangeLog
===================================================================
--- xfce4-screenshooter-plugin/trunk/ChangeLog	2008-11-02 09:35:57 UTC (rev 5907)
+++ xfce4-screenshooter-plugin/trunk/ChangeLog	2008-11-02 14:24:00 UTC (rev 5908)
@@ -1,3 +1,9 @@
+2008-11-02 jeromeg
+
+  * lib/screenshooter-dialogs.c:
+    - (cb_combo_active_item_changed) free sd->app before setting the new value.
+    - (add_item) free path, unref file and icon, correctly free names. 
+
 2008-11-01 jeromeg
 
   * lib/screenshooter-dialogs.c, Implement the Open with stuff:

Modified: xfce4-screenshooter-plugin/trunk/TODO
===================================================================
--- xfce4-screenshooter-plugin/trunk/TODO	2008-11-02 09:35:57 UTC (rev 5907)
+++ xfce4-screenshooter-plugin/trunk/TODO	2008-11-02 14:24:00 UTC (rev 5908)
@@ -3,6 +3,7 @@
 * Write some documentation.
 * Update the code comments.
 * Update the website.
+* Correctly free the stuff in the GLists and liststore in screenshooter-dialogs.c
 
 Low priority:
 * Try to get borders captured with compiz.

Modified: xfce4-screenshooter-plugin/trunk/lib/screenshooter-dialogs.c
===================================================================
--- xfce4-screenshooter-plugin/trunk/lib/screenshooter-dialogs.c	2008-11-02 09:35:57 UTC (rev 5907)
+++ xfce4-screenshooter-plugin/trunk/lib/screenshooter-dialogs.c	2008-11-02 14:24:00 UTC (rev 5908)
@@ -112,6 +112,9 @@
   
   gtk_tree_model_get (model, &iter, 2, &active_command, -1);
   
+  if (sd->app != NULL)
+    g_free (sd->app);
+  
   sd->app = active_command; 
 }
 
@@ -132,6 +135,9 @@
       
       pixbuf = 
         gdk_pixbuf_new_from_file_at_size (path, 22, 22, NULL);
+      
+      g_free (path);
+      g_object_unref (file);
     }
   else
     {
@@ -153,7 +159,7 @@
                                           NULL);
             }                                          
           
-          g_free (names);                                             
+          g_strfreev (names);                                        
         }
     }
   
@@ -166,6 +172,7 @@
   g_free (name);
   if (pixbuf != NULL)
     g_object_unref (pixbuf);
+  g_object_unref (icon);
 }