[Goodies-commits] r4807 - in xfce4-dict/trunk: . lib

[Enrico Troeger]

Author: enrico
Date: 2008-05-16 15:43:57 +0000 (Fri, 16 May 2008)
New Revision: 4807

Modified:
   xfce4-dict/trunk/ChangeLog
   xfce4-dict/trunk/lib/common.c
Log:
Fix crash due to accessing invalid memory when reading the config file (patch by Federico G. Schwindt, thanks).


Modified: xfce4-dict/trunk/ChangeLog
===================================================================
--- xfce4-dict/trunk/ChangeLog	2008-05-16 07:05:20 UTC (rev 4806)
+++ xfce4-dict/trunk/ChangeLog	2008-05-16 15:43:57 UTC (rev 4807)
@@ -1,3 +1,9 @@
+2008-05-16  Enrico Tröger  <enrico(dot)troeger(at)uvena(dot)de>
+
+ * Fix crash due to accessing invalid memory when reading the
+   config file (patch by Federico G. Schwindt, thanks).
+
+
 2008-05-15  Enrico Tröger  <enrico(dot)troeger(at)uvena(dot)de>
 
  * New release: 0.4.0.

Modified: xfce4-dict/trunk/lib/common.c
===================================================================
--- xfce4-dict/trunk/lib/common.c	2008-05-16 07:05:20 UTC (rev 4806)
+++ xfce4-dict/trunk/lib/common.c	2008-05-16 15:43:57 UTC (rev 4807)
@@ -308,8 +308,6 @@
 
 		geo = xfce_rc_read_entry(rc, "geometry", geo);
 		parse_geometry(dd, geo);
-
-		xfce_rc_close(rc);
 	}
 
 	dd->mode_default = mode_default;
@@ -326,6 +324,8 @@
 	dd->dictionary = g_strdup(dict);
 	dd->spell_bin = g_strdup(spell_bin);
 	dd->spell_dictionary = g_strdup(spell_dictionary);
+
+	xfce_rc_close(rc);
 }