[Goodies-commits] r2804 - in xfce4-places-plugin/branches/umount: . panel-plugin

Diego Ongaro ongardie at xfce.org
Sun Jun 3 07:09:43 CEST 2007


Author: ongardie
Date: 2007-06-03 05:09:43 +0000 (Sun, 03 Jun 2007)
New Revision: 2804

Modified:
   xfce4-places-plugin/branches/umount/ChangeLog
   xfce4-places-plugin/branches/umount/panel-plugin/view.c
Log:
2007-06-03	Diego Ongaro <ongardie at gmail.com>

* unmount branch: improved UI for context menu



Modified: xfce4-places-plugin/branches/umount/ChangeLog
===================================================================
--- xfce4-places-plugin/branches/umount/ChangeLog	2007-05-31 18:16:25 UTC (rev 2803)
+++ xfce4-places-plugin/branches/umount/ChangeLog	2007-06-03 05:09:43 UTC (rev 2804)
@@ -1,3 +1,7 @@
+2007-06-03	Diego Ongaro <ongardie at gmail.com>
+
+	* unmount branch: improved UI for context menu
+
 2007-05-27	Diego Ongaro <ongardie at gmail.com>
 
 	* unmount branch: added "actions" to bookmarks.

Modified: xfce4-places-plugin/branches/umount/panel-plugin/view.c
===================================================================
--- xfce4-places-plugin/branches/umount/panel-plugin/view.c	2007-05-31 18:16:25 UTC (rev 2803)
+++ xfce4-places-plugin/branches/umount/panel-plugin/view.c	2007-06-03 05:09:43 UTC (rev 2804)
@@ -80,7 +80,6 @@
 
 
 /********** Initialization & Finalization **********/
-
 void
 places_view_init(PlacesData *pd)
 {
@@ -538,8 +537,8 @@
         const gchar *uri = (const gchar*) g_object_get_data(G_OBJECT(menu_item), "uri");
         if(uri != NULL){
             places_load_thunar(uri);
+            return FALSE;
         }
-
         return TRUE;
     }
 
@@ -561,9 +560,11 @@
                 gtk_menu_shell_append(GTK_MENU_SHELL(context), context_item);
                 actions = actions->next;
             }
-            gtk_menu_popup(GTK_MENU(context), NULL, NULL,
+            gtk_menu_popup(GTK_MENU(context),
                            NULL, NULL,
+                           NULL, NULL,
                            event->button, event->time);
+            g_signal_connect_swapped(context, "deactivate", G_CALLBACK(places_view_open_menu), pd);
         }
 
         return TRUE;
@@ -607,8 +608,7 @@
     if(actions != NULL)
         g_object_set_data_full(G_OBJECT(item), "actions", actions, (GDestroyNotify) g_slist_free);
 
-    // TODO: click on button and release on menu item to open thunar no longer works (this is strictly button PRESS)
-    g_signal_connect(item, "button-press-event",
+    g_signal_connect(item, "button-release-event",
                      G_CALLBACK(places_view_cb_menu_item_press), pd);
 
     gtk_menu_shell_append(GTK_MENU_SHELL(pd->view_menu), item);




More information about the Goodies-commits mailing list