[Goodies-commits] r2694 - in xfce4-places-plugin/trunk: . panel-plugin
Diego Ongaro
ongardie at xfce.org
Fri Apr 20 23:31:11 CEST 2007
Author: ongardie
Date: 2007-04-20 21:31:11 +0000 (Fri, 20 Apr 2007)
New Revision: 2694
Modified:
xfce4-places-plugin/trunk/ChangeLog
xfce4-places-plugin/trunk/panel-plugin/places.h
xfce4-places-plugin/trunk/panel-plugin/view.c
Log:
2007-04-20 Diego Ongaro <ongardie at gmail.com>
* view.c: Now using g_object_ref_sink() and g_object_unref() on tooltips.
Modified: xfce4-places-plugin/trunk/ChangeLog
===================================================================
--- xfce4-places-plugin/trunk/ChangeLog 2007-04-20 20:10:49 UTC (rev 2693)
+++ xfce4-places-plugin/trunk/ChangeLog 2007-04-20 21:31:11 UTC (rev 2694)
@@ -4,6 +4,7 @@
* model*.c: Added include for config.h for i18n, DBG
* view.c: Disabled Recent Documents for gtk < v2.10.
Replaced gtk_image_clear() call since it's new in gtk v2.8.
+ Now using g_object_ref_sink() and g_object_unref() on tooltips.
2007-04-14 Diego Ongaro <ongardie at gmail.com>
Modified: xfce4-places-plugin/trunk/panel-plugin/places.h
===================================================================
--- xfce4-places-plugin/trunk/panel-plugin/places.h 2007-04-20 20:10:49 UTC (rev 2693)
+++ xfce4-places-plugin/trunk/panel-plugin/places.h 2007-04-20 21:31:11 UTC (rev 2694)
@@ -28,16 +28,17 @@
typedef struct
{
// plugin
- XfcePanelPlugin *plugin;
+ XfcePanelPlugin *plugin;
// view
- GtkWidget *view_button;
- GtkWidget *view_button_image;
- GtkWidget *view_menu;
- gulong view_theme_timeout_id;
+ GtkWidget *view_button;
+ GtkWidget *view_button_image;
+ GtkWidget *view_menu;
+ GtkTooltips *view_tooltips;
+ gulong view_theme_timeout_id;
// model
- gpointer bookmarks;
+ gpointer bookmarks;
} PlacesData;
Modified: xfce4-places-plugin/trunk/panel-plugin/view.c
===================================================================
--- xfce4-places-plugin/trunk/panel-plugin/view.c 2007-04-20 20:10:49 UTC (rev 2693)
+++ xfce4-places-plugin/trunk/panel-plugin/view.c 2007-04-20 21:31:11 UTC (rev 2694)
@@ -91,18 +91,17 @@
DBG("initializing");
gpointer icon_theme_class;
- GtkTooltips *tooltips;
pd->view_menu = NULL;
- tooltips = gtk_tooltips_new(); // TODO: need to ref/unref?
+ pd->view_tooltips = g_object_ref_sink(gtk_tooltips_new());
// init button
pd->view_button = xfce_create_panel_toggle_button();
gtk_widget_show (pd->view_button);
gtk_container_add(GTK_CONTAINER(pd->plugin), pd->view_button);
gtk_button_set_focus_on_click(GTK_BUTTON(pd->view_button), FALSE);
- gtk_tooltips_set_tip(tooltips, pd->view_button, _("Places"), NULL);
+ gtk_tooltips_set_tip(pd->view_tooltips, pd->view_button, _("Places"), NULL);
pd->view_button_image = gtk_image_new();
// TODO: why does xfdesktop ref the new image?
@@ -135,6 +134,7 @@
places_view_destroy_menu(pd);
g_signal_remove_emission_hook(g_signal_lookup("changed", GTK_TYPE_ICON_THEME),
pd->view_theme_timeout_id);
+ g_object_unref(pd->view_tooltips);
}
/********** UI Helpers **********/
More information about the Goodies-commits
mailing list